Skip to content

Conversation

@Batch0101
Copy link

@Batch0101 Batch0101 commented Jan 11, 2026

  • Add CleanProjectDialog component with multi-step wizard
  • Add smart cleanup/remove button that adapts to project status
  • Add IPC handlers for cleanup operations with Python backend integration
  • Add comprehensive English and French translations
  • Implement archive mode for safe data recovery
  • Fix issue with removing broken/uninitialized projects from project list

This feature allows users to:

  1. Remove broken projects from Auto-Claude's project list
  2. Clean Auto-Claude data from initialized projects with preview
  3. Choose between archive (recoverable) or permanent delete modes
  4. See exactly what will be cleaned and how much space will be freed

The smart button automatically detects project status and shows the appropriate action (Remove vs Clean) based on whether the project is initialized.

Base Branch

  • This PR targets the develop branch (required for all feature/fix PRs)
  • This PR targets main (hotfix only - maintainers)

Description

Related Issue

Closes #

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 📚 Documentation
  • ♻️ Refactor
  • 🧪 Test

Area

  • Frontend
  • Backend
  • Fullstack

Commit Message Format

Follow conventional commits: <type>: <subject>

Types: feat, fix, docs, style, refactor, test, chore

Example: feat: add user authentication system

Checklist

  • I've synced with develop branch
  • I've tested my changes locally
  • I've followed the code principles (SOLID, DRY, KISS)
  • My PR is small and focused (< 400 lines ideally)

CI/Testing Requirements

  • All CI checks pass
  • All existing tests pass
  • New features include test coverage
  • Bug fixes include regression tests

Screenshots

Before After

Feature Toggle

  • Behind localStorage flag: use_feature_name
  • Behind settings toggle
  • Behind environment variable/config
  • N/A - Feature is complete and ready for all users

Breaking Changes

Breaking: Yes / No

Details:

Summary by CodeRabbit

  • New Features

    • Project cleanup workflow: preview removable items, choose archive or delete, confirm by typing the required word, run cleanup, and view results (items archived/deleted, reclaimed size, duration).
    • Clean project modal added and accessible from project tabs; smart Clean/Remove action on tabs for quick access.
  • Localization

    • English and French UI strings added for cleanup and project removal flows.

✏️ Tip: You can customize this high-level summary in your review settings.

AndyMik90 and others added 30 commits December 22, 2025 20:20
- Add comprehensive branching strategy documentation
- Explain main, develop, feature, fix, release, and hotfix branches
- Clarify that all PRs should target develop (not main)
- Add release process documentation for maintainers
- Update PR process to branch from develop
- Expand table of contents with new sections
* refactor: restructure project to Apps/frontend and Apps/backend

- Move auto-claude-ui to Apps/frontend with feature-based architecture
- Move auto-claude to Apps/backend
- Switch from pnpm to npm for frontend
- Update Node.js requirement to v24.12.0 LTS
- Add pre-commit hooks for lint, typecheck, and security audit
- Add commit-msg hook for conventional commits
- Fix CommonJS compatibility issues (postcss.config, postinstall scripts)
- Update README with comprehensive setup and contribution guidelines
- Configure ESLint to ignore .cjs files
- 0 npm vulnerabilities

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

* feat(refactor): clean code and move to npm

* feat(refactor): clean code and move to npm

* chore: update to v2.7.0, remove Docker deps (LadybugDB is embedded)

* feat: v2.8.0 - update workflows and configs for Apps/ structure, npm

* fix: resolve Python lint errors (F401, I001)

* fix: update test paths for Apps/backend structure

* fix: add missing facade files and update paths for Apps/backend structure

- Fix ruff lint error I001 in auto_claude_tools.py
- Create missing facade files to match upstream (agent, ci_discovery, critique, etc.)
- Update test paths from auto-claude/ to Apps/backend/
- Update .pre-commit-config.yaml paths for Apps/ structure
- Add pytest to pre-commit hooks (skip slow/integration/Windows-incompatible tests)
- Fix Unicode encoding in test_agent_architecture.py for Windows

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

* feat: improve readme

* fix: new path

* fix: correct release workflow and docs for Apps/ restructure

- Fix ARM64 macOS build: pnpm → npm, auto-claude-ui → Apps/frontend
- Fix artifact upload paths in release.yml
- Update Node.js version to 24 for consistency
- Update CLI-USAGE.md with Apps/backend paths
- Update RELEASE.md with Apps/frontend/package.json paths

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* refactor: rename Apps/ to apps/ and fix backend path resolution

- Rename Apps/ folder to apps/ for consistency with JS/Node conventions
- Update all path references across CI/CD workflows, docs, and config files
- Fix frontend Python path resolver to look for 'backend' instead of 'auto-claude'
- Update path-resolver.ts to correctly find apps/backend in development mode

This completes the Apps restructure from PR AndyMik90#122 and prepares for v2.8.0 release.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(electron): correct preload script path from .js to .mjs

electron-vite builds the preload script as ESM (index.mjs) but the main
process was looking for CommonJS (index.js). This caused the preload to
fail silently, making the app fall back to browser mock mode with fake
data and non-functional IPC handlers.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* - Introduced `dev:debug` script to enable debugging during development.
- Added `dev:mcp` script for running the frontend in MCP mode.

These enhancements streamline the development process for frontend developers.

* refactor(memory): make Graphiti memory mandatory and remove Docker dependency

Memory is now a core component of Auto Claude rather than optional:
- Python 3.12+ is required for the backend (not just memory layer)
- Graphiti is enabled by default in .env.example
- Removed all FalkorDB/Docker references (migrated to embedded LadybugDB)
- Deleted guides/DOCKER-SETUP.md and docker-handlers.ts
- Updated onboarding UI to remove "optional" language
- Updated all documentation to reflect LadybugDB architecture

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* feat: add cross-platform Windows support for npm scripts

- Add scripts/install-backend.js for cross-platform Python venv setup
  - Auto-detects Python 3.12 (py -3.12 on Windows, python3.12 on Unix)
  - Handles platform-specific venv paths
- Add scripts/test-backend.js for cross-platform pytest execution
- Update package.json to use Node.js scripts instead of shell commands
- Update CONTRIBUTING.md with correct paths and instructions:
  - apps/backend/ and apps/frontend/ paths
  - Python 3.12 requirement (memory system now required)
  - Platform-specific install commands (winget, brew, apt)
  - npm instead of pnpm
  - Quick Start section with npm run install:all

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* remove doc

* fix(frontend): correct Ollama detector script path after apps restructure

The Ollama status check was failing because memory-handlers.ts
was looking for ollama_model_detector.py at auto-claude/ but the
script is now at apps/backend/ after the directory restructure.

This caused "Ollama not running" to display even when Ollama was
actually running and accessible.

* chore: bump version to 2.7.2

Downgrade version from 2.8.0 to 2.7.2 as the Apps/ restructure
is better suited as a patch release rather than a minor release.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* chore: update package-lock.json for Windows compatibility

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* docs(contributing): add hotfix workflow and update paths for apps/ structure

Add Git Flow hotfix workflow documentation with step-by-step guide
and ASCII diagram showing the branching strategy.

Update all paths from auto-claude/auto-claude-ui to apps/backend/apps/frontend
and migrate package manager references from pnpm to npm to match the
new project structure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(ci): remove duplicate ARM64 build from Intel runner

The Intel runner was building both x64 and arm64 architectures,
while a separate ARM64 runner also builds arm64 natively. This
caused duplicate ARM64 builds, wasting CI resources.

Now each runner builds only its native architecture:
- Intel runner: x64 only
- ARM64 runner: arm64 only

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

---------

Co-authored-by: Alex Madera <[email protected]>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.5 <[email protected]>
…Mik90#141)

* feat(ollama): add real-time download progress tracking for model downloads

Implement comprehensive download progress tracking with:
- NDJSON parsing for streaming progress data from Ollama API
- Real-time speed calculation (MB/s, KB/s, B/s) with useRef for delta tracking
- Time remaining estimation based on download speed
- Animated progress bars in OllamaModelSelector component
- IPC event streaming from main process to renderer
- Proper listener management with cleanup functions

Changes:
- memory-handlers.ts: Parse NDJSON from Ollama stderr, emit progress events
- OllamaModelSelector.tsx: Display progress bars with speed and time remaining
- project-api.ts: Implement onDownloadProgress listener with cleanup
- ipc.ts types: Define onDownloadProgress listener interface
- infrastructure-mock.ts: Add mock implementation for browser testing

This allows users to see real-time feedback when downloading Ollama models,
including percentage complete, current download speed, and estimated time remaining.

* test: add focused test coverage for Ollama download progress feature

Add unit tests for the critical paths of the real-time download progress tracking:

- Progress calculation tests (52 tests): Speed/time/percentage calculations with comprehensive edge case coverage (zero speeds, NaN, Infinity, large numbers)
- NDJSON parser tests (33 tests): Streaming JSON parsing from Ollama, buffer management for incomplete lines, error handling

All 562 unit tests passing with clean dependencies. Tests focus on critical mathematical logic and data processing - the most important paths that need verification.

Test coverage:
✅ Speed calculation and formatting (B/s, KB/s, MB/s)
✅ Time remaining calculations (seconds, minutes, hours)
✅ Percentage clamping (0-100%)
✅ NDJSON streaming with partial line buffering
✅ Invalid JSON handling
✅ Real Ollama API responses
✅ Multi-chunk streaming scenarios

* docs: add comprehensive JSDoc docstrings for Ollama download progress feature

- Enhanced OllamaModelSelector component with detailed JSDoc
  * Documented component props, behavior, and usage examples
  * Added docstrings to internal functions (checkInstalledModels, handleDownload, handleSelect)
  * Explained progress tracking algorithm and useRef usage

- Improved memory-handlers.ts documentation
  * Added docstring to main registerMemoryHandlers function
  * Documented all Ollama-related IPC handlers (check-status, list-embedding-models, pull-model)
  * Added JSDoc to executeOllamaDetector helper function
  * Documented interface types (OllamaStatus, OllamaModel, OllamaEmbeddingModel, OllamaPullResult)
  * Explained NDJSON parsing and progress event structure

- Enhanced test file documentation
  * Added docstrings to NDJSON parser test utilities with algorithm explanation
  * Documented all calculation functions (speed, time, percentage)
  * Added detailed comments on formatting and bounds-checking logic

- Improved overall code maintainability
  * Docstring coverage now meets 80%+ threshold for code review
  * Clear explanation of progress tracking implementation details
  * Better context for future maintainers working with download streaming

* feat: add batch task creation and management CLI commands

- Handle batch task creation from JSON files
- Show status of all specs in project
- Cleanup tool for completed specs
- Full integration with new apps/backend structure
- Compatible with implementation_plan.json workflow

* test: add batch task test file and testing checklist

- batch_test.json: Sample tasks for testing batch creation
- TESTING_CHECKLIST.md: Comprehensive testing guide for Ollama and batch tasks
- Includes UI testing steps, CLI testing steps, and edge cases
- Ready for manual and automated testing

* chore: update package-lock.json to match v2.7.2

* test: update checklist with verification results and architecture validation

* docs: add comprehensive implementation summary for Ollama + Batch features

* docs: add comprehensive Phase 2 testing guide with checklists and procedures

* docs: add NEXT_STEPS guide for Phase 2 testing

* fix: resolve merge conflict in project-api.ts from Ollama feature cherry-pick

* fix: remove duplicate Ollama check status handler registration

* test: update checklist with Phase 2 bug findings and fixes

---------

Co-authored-by: ray <[email protected]>
Implemented promise queue pattern in PythonEnvManager to handle
concurrent initialization requests. Previously, multiple simultaneous
requests (e.g., startup + merge) would fail with "Already
initializing" error.

Also fixed parsePythonCommand() to handle file paths with spaces by
checking file existence before splitting on whitespace.

Changes:
- Added initializationPromise field to queue concurrent requests
- Split initialize() into public and private _doInitialize()
- Enhanced parsePythonCommand() with existsSync() check

Co-authored-by: Joris Slagter <[email protected]>
)

Removes the legacy 'auto-claude' path from the possiblePaths array
in agent-process.ts. This path was from before the monorepo
restructure (v2.7.2) and is no longer needed.

The legacy path was causing spec_runner.py to be looked up at the
wrong location:
- OLD (wrong): /path/to/auto-claude/auto-claude/runners/spec_runner.py
- NEW (correct): /path/to/apps/backend/runners/spec_runner.py

This aligns with the new monorepo structure where all backend code
lives in apps/backend/.

Fixes AndyMik90#147

Co-authored-by: Joris Slagter <[email protected]>
* fix: Linear API authentication and GraphQL types

- Remove Bearer prefix from Authorization header (Linear API keys are sent directly)
- Change GraphQL variable types from String! to ID! for teamId and issue IDs
- Improve error handling to show detailed Linear API error messages

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix: Radix Select empty value error in Linear import modal

Use '__all__' sentinel value instead of empty string for "All projects"
option, as Radix Select does not allow empty string values.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* feat: add CodeRabbit configuration file

Introduce a new .coderabbit.yaml file to configure CodeRabbit settings, including review profiles, automatic review options, path filters, and specific instructions for different file types. This enhances the code review process by providing tailored guidelines for Python, TypeScript, and test files.

* fix: correct GraphQL types for Linear team queries

Linear API uses different types for different queries:
- team(id:) expects String!
- issues(filter: { team: { id: { eq: } } }) expects ID!

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix: refresh task list after Linear import

Call loadTasks() after successful Linear import to update the kanban
board without requiring a page reload.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* cleanup

* cleanup

* fix: address CodeRabbit review comments for Linear integration

- Fix unsafe JSON parsing: check response.ok before parsing JSON to handle
  non-JSON error responses (e.g., 503 from proxy) gracefully
- Use ID! type instead of String! for teamId in LINEAR_GET_PROJECTS query
  for GraphQL type consistency
- Remove debug console.log (ESLint config only allows warn/error)
- Refresh task list on partial import success (imported > 0) instead of
  requiring full success
- Fix pre-existing TypeScript and lint issues blocking commit

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* version sync logic

* lints for develop branch

* chore: update CI workflow to include develop branch

- Modified the CI configuration to trigger on pushes and pull requests to both main and develop branches, enhancing the workflow for development and integration processes.

* fix: update project directory auto-detection for apps/backend structure

The project directory auto-detection was checking for the old `auto-claude/`
directory name but needed to check for `apps/backend/`. When running from
`apps/backend/`, the directory name is `backend` not `auto-claude`, so the
check would fail and `project_dir` would incorrectly remain as `apps/backend/`
instead of resolving to the project root (2 levels up).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix: use GraphQL variables instead of string interpolation in LINEAR_GET_ISSUES

Replace direct string interpolation of teamId and linearProjectId with
proper GraphQL variables. This prevents potential query syntax errors if
IDs contain special characters like double quotes, and aligns with the
variable-based approach used elsewhere in the file.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(ui): correct logging level and await loadTasks on import complete

- Change console.warn to console.log for import success messages
  (warn is incorrect severity for normal completion)
- Make onImportComplete callback async and await loadTasks()
  to prevent potential unhandled promise rejections

Applies CodeRabbit review feedback across 3 LinearTaskImportModal usages.

* fix(hooks): use POSIX-compliant find instead of bash glob

The pre-commit hook uses #!/bin/sh but had bash-specific ** glob
pattern for staging ruff-formatted files. The ** pattern only works
in bash with globstar enabled - in POSIX sh it expands literally
and won't match subdirectories, causing formatted files in nested
directories to not be staged.

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
…_progress

When a user drags a running task back to Planning (or any other column),
the process was not being stopped, leaving a "ghost" process that
prevented deletion with "Cannot delete a running task" error.

Now the task process is automatically killed when status changes away
from in_progress, ensuring the process state stays in sync with the UI.
* feat: add UI scale feature

* refactor: extract UI scale bounds to shared constants

* fix: duplicated import
…90#154)

* fix: analyzer Python compatibility and settings integration

Fixes project index analyzer failing with TypeError on Python type hints.

Changes:
- Added 'from __future__ import annotations' to all analysis modules
- Fixed project discovery to support new analyzer JSON format
- Read Python path directly from settings.json instead of pythonEnvManager
- Added stderr/stdout logging for analyzer debugging

Resolves 'Discovered 0 files' and 'TypeError: unsupported operand type' issues.

* auto-claude: subtask-1-1 - Hide status badge when execution phase badge is showing

When a task has an active execution (planning, coding, etc.), the
execution phase badge already displays the correct state with a spinner.
The status badge was also rendering, causing duplicate/confusing badges
(e.g., both "Planning" and "Pending" showing at the same time).

This fix wraps the status badge in a conditional that only renders when
there's no active execution, eliminating the redundant badge display.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(ipc): remove unused pythonEnvManager parameter and fix ES6 import

Address CodeRabbit review feedback:
- Remove unused pythonEnvManager parameter from registerProjectContextHandlers
  and registerContextHandlers (the code reads Python path directly from
  settings.json instead)
- Replace require('electron').app with proper ES6 import for consistency

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* chore(lint): fix import sorting in analysis module

Run ruff --fix to resolve I001 lint errors after merging develop.
All 23 files in apps/backend/analysis/ now have properly sorted imports.

---------

Co-authored-by: Joris Slagter <[email protected]>
Co-authored-by: Claude Opus 4.5 <[email protected]>
* fix(core): add task persistence, terminal handling, and HTTP 300 fixes

Consolidated bug fixes from PRs AndyMik90#168, AndyMik90#170, AndyMik90#171:

- Task persistence (AndyMik90#168): Scan worktrees for tasks on app restart
  to prevent loss of in-progress work and wasted API credits. Tasks
  in .worktrees/*/specs are now loaded and deduplicated with main.

- Terminal buttons (AndyMik90#170): Fix "Open Terminal" buttons silently
  failing on macOS by properly awaiting createTerminal() Promise.
  Added useTerminalHandler hook with loading states and error display.

- HTTP 300 errors (AndyMik90#171): Handle branch/tag name collisions that
  cause update failures. Added validation script to prevent conflicts
  before releases and user-friendly error messages with manual
  download links.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(platform): add path resolution, spaces handling, and XDG support

This commit consolidates multiple bug fixes from community PRs:

- PR AndyMik90#187: Path resolution fix - Update path detection to find apps/backend
  instead of legacy auto-claude directory after v2.7.2 restructure

- PR AndyMik90#182/AndyMik90#155: Python path spaces fix - Improve parsePythonCommand() to
  handle quoted paths and paths containing spaces without splitting

- PR AndyMik90#161: Ollama detection fix - Add new apps structure paths for
  ollama_model_detector.py script discovery

- PR AndyMik90#160: AppImage support - Add XDG Base Directory compliant paths for
  Linux sandboxed environments (AppImage, Flatpak, Snap). New files:
  - config-paths.ts: XDG path utilities
  - fs-utils.ts: Filesystem utilities with fallback support

- PR AndyMik90#159: gh CLI PATH fix - Add getAugmentedEnv() utility to include
  common binary locations (Homebrew, snap, local) in PATH for child
  processes. Fixes gh CLI not found when app launched from Finder/Dock.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix: address CodeRabbit/Cursor review comments on PR AndyMik90#185

Fixes from code review:
- http-client.ts: Use GITHUB_CONFIG instead of hardcoded owner in HTTP 300 error message
- validate-release.js: Fix substring matching bug in branch detection that could cause false positives (e.g., v2.7 matching v2.7.2)
- bump-version.js: Remove unnecessary try-catch wrapper (exec() already exits on failure)
- execution-handlers.ts: Capture original subtask status before mutation for accurate logging
- fs-utils.ts: Add error handling to safeWriteFile with proper logging

Dismissed as trivial/not applicable:
- config-paths.ts: Exhaustive switch check (over-engineering)
- env-utils.ts: PATH priority documentation (existing comments sufficient)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix: address additional CodeRabbit review comments (round 2)

Fixes from second round of code review:
- fs-utils.ts: Wrap test file cleanup in try-catch for Windows file locking
- fs-utils.ts: Add error handling to safeReadFile for consistency with safeWriteFile
- http-client.ts: Use GITHUB_CONFIG in fetchJson (missed in first round)
- validate-release.js: Exclude symbolic refs (origin/HEAD -> origin/main) from branch check
- python-detector.ts: Return cleanPath instead of pythonPath for empty input edge case

Dismissed as trivial/not applicable:
- execution-handlers.ts: Redundant checkSubtasksCompletion call (micro-optimization)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
* chore: update README version to 2.7.1

Updated the version badge and download links in the README to reflect the new release version 2.7.1, ensuring users have the correct information for downloading the latest builds.

* feat(releases): add beta release system with user opt-in

Implements a complete beta release workflow that allows users to opt-in
to receiving pre-release versions. This enables testing new features
before they're included in stable releases.

Changes:
- Add beta-release.yml workflow for creating beta releases from develop
- Add betaUpdates setting with UI toggle in Settings > Updates
- Add update channel support to electron-updater (beta vs latest)
- Extract shared settings-utils.ts to reduce code duplication
- Add prepare-release.yml workflow for automated release preparation
- Document beta release process in CONTRIBUTING.md and RELEASE.md

Users can enable beta updates in Settings > Updates, and maintainers
can trigger beta releases via the GitHub Actions workflow.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* workflow update

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
* chore: update README version to 2.7.1

Updated the version badge and download links in the README to reflect the new release version 2.7.1, ensuring users have the correct information for downloading the latest builds.

* feat(releases): add beta release system with user opt-in

Implements a complete beta release workflow that allows users to opt-in
to receiving pre-release versions. This enables testing new features
before they're included in stable releases.

Changes:
- Add beta-release.yml workflow for creating beta releases from develop
- Add betaUpdates setting with UI toggle in Settings > Updates
- Add update channel support to electron-updater (beta vs latest)
- Extract shared settings-utils.ts to reduce code duplication
- Add prepare-release.yml workflow for automated release preparation
- Document beta release process in CONTRIBUTING.md and RELEASE.md

Users can enable beta updates in Settings > Updates, and maintainers
can trigger beta releases via the GitHub Actions workflow.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* workflow update

* ci(github): update Discord link and redirect feature requests to discussions

Update Discord invite link to correct URL (QhRnz9m5HE) across all GitHub
templates and workflows. Redirect feature requests from issue template
to GitHub Discussions for better community engagement.

Changes:
- config.yml: Add feature request link to Discussions, fix Discord URL
- question.yml: Update Discord link in pre-question guidance
- welcome.yml: Update Discord link in first-time contributor message

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
- Change branch reference from main to develop
- Fix contribution guide link to use full URL
- Remove hyphen from "Auto Claude" in welcome message
…tup (AndyMik90#180 AndyMik90#167) (AndyMik90#208)

This fixes critical bug where macOS users with default Python 3.9.6 couldn't use Auto-Claude because claude-agent-sdk requires Python 3.10+.

Root Cause:
- Auto-Claude doesn't bundle Python, relies on system Python
- python-detector.ts accepted any Python 3.x without checking minimum version
- macOS ships with Python 3.9.6 by default (incompatible)
- GitHub Actions runners didn't explicitly set Python version

Changes:
1. python-detector.ts:
   - Added getPythonVersion() to extract version from command
   - Added validatePythonVersion() to check if >= 3.10.0
   - Updated findPythonCommand() to skip Python < 3.10 with clear error messages

2. python-env-manager.ts:
   - Import and use findPythonCommand() (already has version validation)
   - Simplified findSystemPython() to use shared validation logic
   - Updated error message from "Python 3.9+" to "Python 3.10+" with download link

3. .github/workflows/release.yml:
   - Added Python 3.11 setup to all 4 build jobs (macOS Intel, macOS ARM64, Windows, Linux)
   - Ensures consistent Python version across all platforms during build

Impact:
- macOS users with Python 3.9 now see clear error with download link
- macOS users with Python 3.10+ work normally
- CI/CD builds use consistent Python 3.11
- Prevents "ModuleNotFoundError: dotenv" and dependency install failures

Fixes AndyMik90#180, AndyMik90#167

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.5 <[email protected]>
* feat: Add OpenRouter as LLM/embedding provider

Add OpenRouter provider support for Graphiti memory integration,
enabling access to multiple LLM providers through a single API.

Changes:
Backend:
- Created openrouter_llm.py: OpenRouter LLM provider using OpenAI-compatible API
- Created openrouter_embedder.py: OpenRouter embedder provider
- Updated config.py: Added OpenRouter to provider enums and configuration
  - New fields: openrouter_api_key, openrouter_base_url, openrouter_llm_model, openrouter_embedding_model
  - Validation methods updated for OpenRouter
- Updated factory.py: Added OpenRouter to LLM and embedder factories
- Updated provider __init__.py files: Exported new OpenRouter functions

Frontend:
- Updated project.ts types: Added 'openrouter' to provider type unions
  - GraphitiProviderConfig extended with OpenRouter fields
- Updated GraphitiStep.tsx: Added OpenRouter to provider arrays
  - LLM_PROVIDERS: 'Multi-provider aggregator'
  - EMBEDDING_PROVIDERS: 'OpenAI-compatible embeddings'
  - Added OpenRouter API key input field with show/hide toggle
  - Link to https://openrouter.ai/keys
- Updated env-handlers.ts: OpenRouter .env generation and parsing
  - Template generation for OPENROUTER_* variables
  - Parsing from .env files with proper type casting

Documentation:
- Updated .env.example with OpenRouter section
  - Configuration examples
  - Popular model recommendations
  - Example configuration (AndyMik90#6)

Fixes AndyMik90#92

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

* refactor: address CodeRabbit review comments for OpenRouter

- Add globalOpenRouterApiKey to settings types and store updates
- Initialize openrouterApiKey from global settings
- Update documentation to include OpenRouter in provider lists
- Add OpenRouter handling to get_embedding_dimension() method
- Add openrouter to provider cleanup list
- Add OpenRouter to get_available_providers() function
- Clarify Legacy comment for openrouterLlmModel

These changes complete the OpenRouter integration by ensuring proper
settings persistence and provider detection across the application.

* fix: apply ruff formatting to OpenRouter code

- Break long error message across multiple lines
- Format provider list with one item per line
- Fixes lint CI failure

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

---------

Co-authored-by: Claude Sonnet 4.5 <[email protected]>
…Mik90#209)

Implements distributed file-based locking for spec number coordination
across main project and all worktrees. Previously, parallel spec creation
could assign the same number to different specs (e.g., 042-bmad-task and
042-gitlab-integration both using number 042).

The fix adds SpecNumberLock class that:
- Acquires exclusive lock before calculating spec numbers
- Scans ALL locations (main project + worktrees) for global maximum
- Creates spec directories atomically within the lock
- Handles stale locks via PID-based detection with 30s timeout

Applied to both Python backend (spec_runner.py flow) and TypeScript
frontend (ideation conversion, GitHub/GitLab issue import).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <[email protected]>
* fix(ideation): add missing event forwarders for status sync

- Add event forwarders in ideation-handlers.ts for progress, log,
  type-complete, type-failed, complete, error, and stopped events
- Fix ideation-type-complete to load actual ideas array from JSON files
  instead of emitting only the count

Resolves UI getting stuck at 0/3 complete during ideation generation.

* fix(ideation): fix UI not updating after actions

- Fix getIdeationSummary to count only active ideas (exclude dismissed/archived)
  This ensures header stats match the visible ideas count
- Add transformSessionFromSnakeCase to properly transform session data
  from backend snake_case to frontend camelCase on ideation-complete event
- Transform raw session before emitting ideation-complete event

Resolves header showing stale counts after dismissing/deleting ideas.

* fix(ideation): improve type safety and async handling in ideation type completion

- Replace synchronous readFileSync with async fsPromises.readFile in ideation-type-complete handler
- Wrap async file read in IIFE with proper error handling to prevent unhandled promise rejections
- Add type validation for IdeationType with VALID_IDEATION_TYPES set and isValidIdeationType guard
- Add validateEnabledTypes function to filter out invalid type values and log dropped entries
- Handle ENOENT separately

* fix(ideation): improve generation state management and error handling

- Add explicit isGenerating flag to prevent race conditions during async operations
- Implement 5-minute timeout for generation with automatic cleanup and error state
- Add ideation-stopped event emission when process is intentionally killed
- Replace console.warn/error with proper ideation-error events in agent-queue
- Add resetGeneratingTypes helper to transition all generating types to a target state
- Filter out dismissed/

* refactor(ideation): improve event listener cleanup and timeout management

- Extract event handler functions in ideation-handlers.ts to enable proper cleanup
- Return cleanup function from registerIdeationHandlers to remove all listeners
- Replace single generationTimeoutId with Map to support multiple concurrent projects
- Add clearGenerationTimeout helper to centralize timeout cleanup logic
- Extract loadIdeationType IIFE to named function for better error context
- Enhance error logging with projectId,

* refactor: use async file read for ideation and roadmap session loading

- Replace synchronous readFileSync with async fsPromises.readFile
- Prevents blocking the event loop during file operations
- Consistent with async pattern used elsewhere in the codebase
- Improved error handling with proper event emission

* fix(agent-queue): improve roadmap completion handling and error reporting

- Add transformRoadmapFromSnakeCase to convert backend snake_case to frontend camelCase
- Transform raw roadmap data before emitting roadmap-complete event
- Add roadmap-error emission for unexpected errors during completion
- Add roadmap-error emission when project path is unavailable
- Remove duplicate ideation-type-complete emission from error handler (event already emitted in loadIdeationType)
- Update error log message
Adds 'from __future__ import annotations' to spec/discovery.py for
Python 3.9+ compatibility with type hints.

This completes the Python compatibility fixes that were partially
applied in previous commits. All 26 analysis and spec Python files
now have the future annotations import.

Related: AndyMik90#128

Co-authored-by: Joris Slagter <[email protected]>
…#241)

* fix: resolve Python detection and backend packaging issues

- Fix backend packaging path (auto-claude -> backend) to match path-resolver.ts expectations
- Add future annotations import to config_parser.py for Python 3.9+ compatibility
- Use findPythonCommand() in project-context-handlers to prioritize Homebrew Python
- Improve Python detection to prefer Homebrew paths over system Python on macOS

This resolves the following issues:
- 'analyzer.py not found' error due to incorrect packaging destination
- TypeError with 'dict | None' syntax on Python < 3.10
- Wrong Python interpreter being used (system Python instead of Homebrew Python 3.10+)

Tested on macOS with packaged app - project index now loads successfully.

* refactor: address PR review feedback

- Extract findHomebrewPython() helper to eliminate code duplication between
  findPythonCommand() and getDefaultPythonCommand()
- Remove hardcoded version-specific paths (python3.12) and rely only on
  generic Homebrew symlinks for better maintainability
- Remove unnecessary 'from __future__ import annotations' from config_parser.py
  since backend requires Python 3.12+ where union types are native

These changes make the code more maintainable, less fragile to Python version
changes, and properly reflect the project's Python 3.12+ requirement.
…#250)

* feat(github): add GitHub automation system for issues and PRs

Implements comprehensive GitHub automation with three major components:

1. Issue Auto-Fix: Automatically creates specs from labeled issues
   - AutoFixButton component with progress tracking
   - useAutoFix hook for config and queue management
   - Backend handlers for spec creation from issues

2. GitHub PRs Tool: AI-powered PR review sidebar
   - New sidebar tab (Cmd+Shift+P) alongside GitHub Issues
   - PRList/PRDetail components for viewing PRs
   - Review system with findings by severity
   - Post review comments to GitHub

3. Issue Triage: Duplicate/spam/feature-creep detection
   - Triage handlers with label application
   - Configurable detection thresholds

Also adds:
- Debug logging (DEBUG=true) for all GitHub handlers
- Backend runners/github module with orchestrator
- AI prompts for PR review, triage, duplicate/spam detection
- dev:debug npm script for development with logging

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(github-runner): resolve import errors for direct script execution

Changes runner.py and orchestrator.py to handle both:
- Package import: `from runners.github import ...`
- Direct script: `python runners/github/runner.py`

Uses try/except pattern for relative vs direct imports.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(github): correct argparse argument order for runner.py

Move --project global argument before subcommand so argparse can
correctly parse it. Fixes "unrecognized arguments: --project" error.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* logs when debug mode is on

* refactor(github): extract service layer and fix linting errors

Major refactoring to improve maintainability and code quality:

Backend (Python):
- Extracted orchestrator.py (2,600 → 835 lines, 68% reduction) into 7 service modules:
  - prompt_manager.py: Prompt template management
  - response_parsers.py: AI response parsing
  - pr_review_engine.py: PR review orchestration
  - triage_engine.py: Issue triage logic
  - autofix_processor.py: Auto-fix workflow
  - batch_processor.py: Batch issue handling
- Fixed 18 ruff linting errors (F401, C405, C414, E741):
  - Removed unused imports (BatchValidationResult, AuditAction, locked_json_write)
  - Optimized collection literals (set([n]) → {n})
  - Removed unnecessary list() calls
  - Renamed ambiguous variable 'l' to 'label' throughout

Frontend (TypeScript):
- Refactored IPC handlers (19% overall reduction) with shared utilities:
  - autofix-handlers.ts: 1,042 → 818 lines
  - pr-handlers.ts: 648 → 543 lines
  - triage-handlers.ts: 437 lines (no duplication)
- Created utils layer: logger, ipc-communicator, project-middleware, subprocess-runner
- Split github-store.ts into focused stores: issues, pr-review, investigation, sync-status
- Split ReviewFindings.tsx into focused components

All imports verified, type checks passing, linting clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
* Add multilingual support and i18n integration

- Implemented i18n framework using `react-i18next` for translation management.
- Added support for English and French languages with translation files.
- Integrated language selector into settings.
- Updated all text strings in UI components to use translation keys.
- Ensured smooth language switching with live updates.

* Migrate remaining hard-coded strings to i18n system

- TaskCard: status labels, review reasons, badges, action buttons
- PhaseProgressIndicator: execution phases, progress labels
- KanbanBoard: drop zone, show archived, tooltips
- CustomModelModal: dialog title, description, labels
- ProactiveSwapListener: account switch notifications
- AgentProfileSelector: phase labels, custom configuration
- GeneralSettings: agent framework option

Added translation keys for en/fr locales in tasks.json, common.json,
and settings.json for complete i18n coverage.

* Add i18n support to dialogs and settings components

- AddFeatureDialog: form labels, validation messages, buttons
- AddProjectModal: dialog steps, form fields, actions
- RateLimitIndicator: rate limit notifications
- RateLimitModal: account switching, upgrade prompts
- AdvancedSettings: updates and notifications sections
- ThemeSettings: theme selection labels
- Updated dialogs.json locales (en/fr)

* Fix truncated 'ready' message in dialogs locales

* Fix backlog terminology in i18n locales

Change "Planning"/"Planification" to standard PM term "Backlog"

* Migrate settings navigation and integration labels to i18n

- AppSettings: nav items, section titles, buttons
- IntegrationSettings: Claude accounts, auto-switch, API keys labels
- Added settings nav/projectSections/integrations translation keys
- Added buttons.saving to common translations

* Migrate AgentProfileSettings and Sidebar init dialog to i18n

- AgentProfileSettings: migrate phase config labels, section title,
  description, and all hardcoded strings to settings namespace
- Sidebar: migrate init dialog strings to dialogs namespace with
  common buttons from common namespace
- Add new translation keys for agent profile settings and update dialog

* Migrate AppSettings navigation labels to i18n

- Add useTranslation hook to AppSettings.tsx
- Replace hardcoded section labels with dynamic translations
- Add projectSections translations for project settings nav
- Add rerunWizardDescription translation key

* Add explicit typing to notificationItems array

Import NotificationSettings type and use keyof to properly type
the notification item keys, removing manual type assertion.
…AndyMik90#266)

* ci: implement enterprise-grade PR quality gates and security scanning

* ci: implement enterprise-grade PR quality gates and security scanning

* fix:pr comments and improve code

* fix: improve commit linting and code quality

* Removed the dependency-review job (i added it)

* fix: address CodeRabbit review comments

- Expand scope pattern to allow uppercase, underscores, slashes, dots
- Add concurrency control to cancel duplicate security scan runs
- Add explanatory comment for Bandit CLI flags
- Remove dependency-review job (requires repo settings)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* docs: update commit lint examples with expanded scope patterns

Show slashes and dots in scope examples to demonstrate
the newly allowed characters (api/users, package.json)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* chore: remove feature request issue template

Feature requests are directed to GitHub Discussions
via the issue template config.yml

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix: address security vulnerabilities in service orchestrator

- Fix port parsing crash on malformed docker-compose entries
- Fix shell injection risk by using shlex.split() with shell=False

Prevents crashes when docker-compose.yml contains environment
variables in port mappings (e.g., '${PORT}:8080') and eliminates
shell injection vulnerabilities in subprocess execution.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
…90#252)

* feat(github): add GitHub automation system for issues and PRs

Implements comprehensive GitHub automation with three major components:

1. Issue Auto-Fix: Automatically creates specs from labeled issues
   - AutoFixButton component with progress tracking
   - useAutoFix hook for config and queue management
   - Backend handlers for spec creation from issues

2. GitHub PRs Tool: AI-powered PR review sidebar
   - New sidebar tab (Cmd+Shift+P) alongside GitHub Issues
   - PRList/PRDetail components for viewing PRs
   - Review system with findings by severity
   - Post review comments to GitHub

3. Issue Triage: Duplicate/spam/feature-creep detection
   - Triage handlers with label application
   - Configurable detection thresholds

Also adds:
- Debug logging (DEBUG=true) for all GitHub handlers
- Backend runners/github module with orchestrator
- AI prompts for PR review, triage, duplicate/spam detection
- dev:debug npm script for development with logging

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(github-runner): resolve import errors for direct script execution

Changes runner.py and orchestrator.py to handle both:
- Package import: `from runners.github import ...`
- Direct script: `python runners/github/runner.py`

Uses try/except pattern for relative vs direct imports.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(github): correct argparse argument order for runner.py

Move --project global argument before subcommand so argparse can
correctly parse it. Fixes "unrecognized arguments: --project" error.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* logs when debug mode is on

* refactor(github): extract service layer and fix linting errors

Major refactoring to improve maintainability and code quality:

Backend (Python):
- Extracted orchestrator.py (2,600 → 835 lines, 68% reduction) into 7 service modules:
  - prompt_manager.py: Prompt template management
  - response_parsers.py: AI response parsing
  - pr_review_engine.py: PR review orchestration
  - triage_engine.py: Issue triage logic
  - autofix_processor.py: Auto-fix workflow
  - batch_processor.py: Batch issue handling
- Fixed 18 ruff linting errors (F401, C405, C414, E741):
  - Removed unused imports (BatchValidationResult, AuditAction, locked_json_write)
  - Optimized collection literals (set([n]) → {n})
  - Removed unnecessary list() calls
  - Renamed ambiguous variable 'l' to 'label' throughout

Frontend (TypeScript):
- Refactored IPC handlers (19% overall reduction) with shared utilities:
  - autofix-handlers.ts: 1,042 → 818 lines
  - pr-handlers.ts: 648 → 543 lines
  - triage-handlers.ts: 437 lines (no duplication)
- Created utils layer: logger, ipc-communicator, project-middleware, subprocess-runner
- Split github-store.ts into focused stores: issues, pr-review, investigation, sync-status
- Split ReviewFindings.tsx into focused components

All imports verified, type checks passing, linting clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

* fixes during testing of PR

* feat(github): implement PR merge, assign, and comment features

- Add auto-assignment when clicking "Run AI Review"
- Implement PR merge functionality with squash method
- Add ability to post comments on PRs
- Display assignees in PR UI
- Add Approve and Merge buttons when review passes
- Update backend gh_client with pr_merge, pr_comment, pr_assign methods
- Create IPC handlers for new PR operations
- Update TypeScript interfaces and browser mocks

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

* Improve PR review AI

* fix(github): use temp files for PR review posting to avoid shell escaping issues

When posting PR reviews with findings containing special characters (backticks,
parentheses, quotes), the shell command was interpreting them as commands instead
of literal text, causing syntax errors.

Changed both postPRReview and postPRComment handlers to write the body content
to temporary files and use gh CLI's --body-file flag instead of --body with
inline content. This safely handles ALL special characters without escaping issues.

Fixes shell errors when posting reviews with suggested fixes containing code snippets.

* fix(i18n): add missing GitHub PRs translation and document i18n requirements

Fixed missing translation key for GitHub PRs feature that was causing
"items.githubPRs" to display instead of the proper translated text.

Added comprehensive i18n guidelines to CLAUDE.md to ensure all future
frontend development follows the translation key pattern instead of
using hardcoded strings.

Also fixed missing deletePRReview mock function in browser-mock.ts
to resolve TypeScript compilation errors.

Changes:
- Added githubPRs translation to en/navigation.json
- Added githubPRs translation to fr/navigation.json
- Added Development Guidelines section to CLAUDE.md with i18n requirements
- Documented translation file locations and namespace usage patterns
- Added deletePRReview mock function to browser-mock.ts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

* fix ui loading

* Github PR fixes

* improve claude.md

* lints/tests

* fix(github): handle PRs exceeding GitHub's 20K line diff limit

- Add PRTooLargeError exception for large PR detection
- Update pr_diff() to catch and raise PRTooLargeError for HTTP 406 errors
- Gracefully handle large PRs by skipping full diff and using individual file patches
- Add diff_truncated flag to PRContext to track when diff was skipped
- Large PRs will now review successfully using per-file diffs instead of failing

Fixes issue with PR AndyMik90#252 which has 100+ files exceeding the 20,000 line limit.

* fix: implement individual file patch fetching for large PRs

The PR review was getting stuck for large PRs (>20K lines) because when we
skipped the full diff due to GitHub API limits, we had no code to analyze.
The individual file patches were also empty, leaving the AI with just
file names and metadata.

Changes:
- Implemented _get_file_patch() to fetch individual patches via git diff
- Updated PR review engine to build composite diff from file patches when
  diff_truncated is True
- Added missing 'state' field to PRContext dataclass
- Limits composite diff to first 50 files for very large PRs
- Shows appropriate warnings when using reconstructed diffs

This allows AI review to proceed with actual code analysis even when the
full PR diff exceeds GitHub's limits.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>

* 1min reduction

* docs: add GitHub Sponsors funding configuration

Enable the Sponsor button on the repository by adding FUNDING.yml
with the AndyMik90 GitHub Sponsors profile.

* feat(github-pr): add orchestrating agent for thorough PR reviews

Implement a new Opus 4.5 orchestrating agent that performs comprehensive
PR reviews regardless of size. Key changes:

- Add orchestrator_reviewer.py with strategic review workflow
- Add review_tools.py with subagent spawning capabilities
- Add pr_orchestrator.md prompt emphasizing thorough analysis
- Add pr_security_agent.md and pr_quality_agent.md subagent prompts
- Integrate orchestrator into pr_review_engine.py with config flag
- Fix critical bug where findings were extracted but not processed
  (indentation issue in _parse_orchestrator_output)

The orchestrator now correctly identifies issues in PRs that were
previously approved as "trivial". Testing showed 7 findings detected
vs 0 before the fix.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* i18n

* fix(github-pr): restrict pr_reviewer to read-only permissions

The PR review agent was using qa_reviewer agent type which has Bash
access, allowing it to checkout branches and make changes during
review. Created new pr_reviewer agent type with BASE_READ_TOOLS only
(no Bash, no writes, no auto-claude tools).

This prevents the PR review from accidentally modifying code or
switching branches during analysis.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(github-pr): robust category mapping and JSON parsing for PR review

The orchestrator PR review was failing to extract findings because:

1. AI generates category names like 'correctness', 'consistency', 'testing'
   that aren't in our ReviewCategory enum - added flexible mapping

2. JSON sometimes embedded in markdown code blocks (```json) which broke
   parsing - added code block extraction as first parsing attempt

Changes:
- Add _CATEGORY_MAPPING dict to map AI categories to valid enum values
- Add _map_category() helper function with fallback to QUALITY
- Add severity parsing with fallback to MEDIUM
- Add markdown code block detection (```json) before raw JSON parsing
- Add _extract_findings_from_data() helper to reduce code duplication
- Apply same fixes to review_tools.py for subagent parsing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(pr-review): improve post findings UX with batch support and feedback

- Fix post findings failing on own PRs by falling back from REQUEST_CHANGES
  to COMMENT when GitHub returns 422 error
- Change status badge to show "Reviewed" instead of "Commented" until
  findings are actually posted to GitHub
- Add success notification when findings are posted (auto-dismisses after 3s)
- Add batch posting support: track posted findings, show "Posted" badge,
  allow posting remaining findings in additional batches
- Show loading state on button while posting

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(github): resolve stale timestamp and null author bugs

- Fix stale timestamp in batch_issues.py: Move updated_at assignment
  BEFORE to_dict() serialization so the saved JSON contains the correct
  timestamp instead of the old value

- Fix AttributeError in context_gatherer.py: Handle null author/user
  fields when GitHub API returns null for deleted/suspended users
  instead of an empty object

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(security): address all high and medium severity PR review findings

HIGH severity fixes:
- Command Injection in autofix-handlers.ts: Use execFileSync with args array
- Command Injection in pr-handlers.ts (3 locations): Use execFileSync + validation
- Command Injection in triage-handlers.ts: Use execFileSync + label validation
- Token Exposure in bot_detection.py: Pass token via GH_TOKEN env var

MEDIUM severity fixes:
- Environment variable leakage in subprocess-runner.ts: Filter to safe vars only
- Debug logging in subprocess-runner.ts: Only log in development mode
- Delimiter escape bypass in sanitize.py: Use regex pattern for variations
- Insecure file permissions in trust.py: Use os.open with 0o600 mode
- No file locking in learning.py: Use FileLock + atomic_write utilities
- Bare except in confidence.py: Log error with specific exception info
- Fragile module import in pr_review_engine.py: Import at module level
- State transition validation in models.py: Enforce can_transition_to()

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* PR followup

* fix(security): add usedforsecurity=False to MD5 hash calls

MD5 is used for generating unique IDs/cache keys, not for security purposes.
Adding usedforsecurity=False resolves Bandit B324 warnings.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(security): address all high-priority PR review findings

Fixes 5 high-priority issues from Auto Claude PR Review:

1. orchestrator_reviewer.py: Token budget tracking now increments
   total_tokens from API response usage data

2. pr_review_engine.py: Async exceptions now re-raise RuntimeError
   instead of silently returning empty results

3. batch_issues.py: IssueBatch.save() now uses locked_json_write
   for atomic file operations with file locking

4. project-middleware.ts: Added validateProjectPath() to prevent
   path traversal attacks (checks absolute, no .., exists, is dir)

5. orchestrator.py: Exception handling now logs full traceback and
   preserves exception type/context in error messages

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(security): address all high-priority PR review findings

Fixes 5 high-priority issues from Auto Claude PR Review:

1. orchestrator_reviewer.py: Token budget tracking now increments
   total_tokens from API response usage data

2. pr_review_engine.py: Async exceptions now re-raise RuntimeError
   instead of silently returning empty results

3. batch_issues.py: IssueBatch.save() now uses locked_json_write
   for atomic file operations with file locking

4. project-middleware.ts: Added validateProjectPath() to prevent
   path traversal attacks (checks absolute, no .., exists, is dir)

5. orchestrator.py: Exception handling now logs full traceback and
   preserves exception type/context in error messages

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* feat(ui): add PR status labels to list view

Add secondary status badges to the PR list showing review state at a glance:
- "Changes Requested" (warning) - PRs with blocking issues (critical/high)
- "Ready to Merge" (green) - PRs with only non-blocking suggestions
- "Ready for Follow-up" (blue) - PRs with new commits since last review

The "Ready for Follow-up" badge uses a cached new commits check from the
store, only shown after the detail view confirms new commits via SHA
comparison. This prevents false positives from PR updatedAt timestamp
changes (which can happen from comments, labels, etc).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* PR labels

* auto-claude: Initialize subtask-based implementation plan

- Workflow type: feature
- Phases: 3
- Subtasks: 6
- Ready for autonomous implementation

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
…yMik90#272)

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.0.15 to 4.0.16.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v4.0.16/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 4.0.16
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@electron/rebuild](https://github.com/electron/rebuild) from 3.7.2 to 4.0.2.
- [Release notes](https://github.com/electron/rebuild/releases)
- [Commits](electron/rebuild@v3.7.2...v4.0.2)

---
updated-dependencies:
- dependency-name: "@electron/rebuild"
  dependency-version: 4.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andy <[email protected]>
* fix(planning): accept bug_fix workflow_type alias

* style(planning): ruff format

* fix: refatored common logic

* fix: remove ruff errors

* fix: remove duplicate _normalize_workflow_type method

Remove the incorrectly placed duplicate method inside ContextLoader class.
The module-level function is the correct implementation being used.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

---------

Co-authored-by: danielfrey63 <[email protected]>
Co-authored-by: Andy <[email protected]>
Co-authored-by: AndyMik90 <[email protected]>
Co-authored-by: Claude Opus 4.5 <[email protected]>
…ow (AndyMik90#276)

When dry_run=true, the workflow skipped creating the version tag but
build jobs still tried to checkout that non-existent tag, causing all
4 platform builds to fail with "git failed with exit code 1".

Now build jobs checkout develop branch for dry runs while still using
the version tag for real releases.

Closes: GitHub Actions run #20464082726
g1331 and others added 2 commits January 11, 2026 14:07
AndyMik90#912)

* fix(planner): enforce implementation_plan schema

* fix(logs): sync planning->coding phase to source

* style(backend): ruff format

* fix(progress): backfill empty description from title

* fix(planner): prevent post-processing during planning

* fix(planner): normalize phase_id and reuse alias mapping

* fix(planner): address review suggestions

* fix(progress): prevent phase field overrides

* test(planner): avoid hardcoded planner.md path

* fix(auto-fix): normalize phase_id and depends_on

* fix(planner): harden plan normalization edge cases

* fix(auto-fix): handle file I/O errors
…ror (ACS-215) (AndyMik90#924)

* fix(graphiti): add isinstance(dict) validation to prevent AttributeError (ACS-215)

Add isinstance(data, dict) check before processing Graphiti search results
to prevent crashes when non-dict objects are returned. This fixes
AttributeError: 'str' object has no attribute 'get' in session history
retrieval.

Affected methods:
- get_session_history() - primary bug location
- get_similar_task_outcomes() - consistency fix
- get_patterns_and_gotchas() - consistency fix (2 locations)

Also add comprehensive unit tests for the bug fix.

* style(tests): fix import order in test_graphiti_search.py

Move 'import sys' to top-level imports before sys_path assignment.

* refactor(tests): improve test coverage and use pytest-asyncio pattern

- Add idempotent guard for sys.path mutation to prevent leaks
- Remove unused spec_dir fixture from graphiti_search
- Fix non-dict objects to include EPISODE_TYPE markers for proper testing
- Fix invalid JSON test to include EPISODE_TYPE_SESSION_INSIGHT marker
- Convert all tests to use @pytest.mark.asyncio, async def, and await
- Improves test coverage for isinstance(dict) guard in all search methods

* fix(tests): correct mock_client.graphiti.search reference

Fix typo where mock_client.graphiti_search was used instead of
mock_client.graphiti.search in test setup.

* refactor(tests): remove unused asyncio import

Tests now use @pytest.mark.asyncio pattern which doesn't require
direct asyncio module usage.

---------

Co-authored-by: StillKnotKnown <[email protected]>
Co-authored-by: Andy <[email protected]>
Copy link
Owner

@AndyMik90 AndyMik90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto Claude PR Review

Merge Verdict: 🔴 BLOCKED

🔴 Blocked - Awaiting maintainer approval for fork PR workflow.

Blocked: 5 workflow(s) awaiting approval. Approve workflows on GitHub to run CI checks.

Risk Assessment

Factor Level Notes
Complexity High Based on lines changed
Security Impact None Based on security findings
Scope Coherence Good Based on structural review

🚨 Blocking Issues (Must Fix)

  • Branch Out of Date: PR branch is behind the base branch and needs to be updated
  • Workflows Pending: 5 workflow(s) awaiting maintainer approval

Findings Summary

  • High: 2 issue(s)
  • Medium: 2 issue(s)
  • Low: 2 issue(s)

Generated by Auto Claude PR Review

Findings (6 selected of 6 total)

🟠 [3b3743ef487c] [HIGH] Missing timeout for spawned Python process could hang indefinitely

📁 apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts:250

The runCleanupCommand function spawns a Python process but never sets a timeout. If the Python script hangs (e.g., waiting for input, network issues, or deadlock), the Promise never resolves and the UI shows a loading spinner forever with no way to recover.

Suggested fix:

Add a timeout mechanism: `const timeout = setTimeout(() => { cleanupProcess.kill(); resolve({ output: '', error: 'Cleanup operation timed out', exitCode: 1 }); }, 300000);` and clear it in the 'close' handler.

🟠 [811ce95422e6] [HIGH] TypeError: duration.toFixed called on potentially undefined value

📁 apps/frontend/src/renderer/components/CleanProjectDialog.tsx:383

In renderResult(), the code calls result.duration.toFixed(1). The CleanupExecuteResult interface in cleanup-handlers.ts defines duration as optional (duration?: number). If the API returns success without duration, this will throw TypeError: Cannot read properties of undefined.

Suggested fix:

Use optional chaining with default: `(result.duration ?? 0).toFixed(1)`

🟡 [d9f353308b9a] [MEDIUM] Accessing undefined properties when cleanup result fields are missing

📁 apps/frontend/src/renderer/components/CleanProjectDialog.tsx:122

The executeCleanup callback accesses response.count, response.size, and response.duration without null checks. According to CleanupExecuteResult interface, these fields are optional. If the API returns {success: true} without these fields, the result object will have undefined values that cause issues in renderResult().

Suggested fix:

Use default values: `count: response.count ?? 0, size: response.size ?? 0, duration: response.duration ?? 0`

🟡 [0775b99a220b] [MEDIUM] parseCleanupResult returns success with zeros when parsing fails

📁 apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts:147

The parseCleanupResult function initializes count/size/duration to 0 and returns them even if no regex matches are found. A completely malformed output returns {count: 0, size: 0, duration: 0} instead of null, so the handler treats parsing failures as successful cleanups with 0 items.

Suggested fix:

Track if any matches were found and return null when no matches: add `let foundMatch = false;` and set to true when regex matches, then `return foundMatch ? { count, size, duration } : null;`

🔵 [c252f69cf5cd] [LOW] Missing radix parameter in parseInt calls

📁 apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts:85

Three parseInt calls (lines 85, 89, 158) are missing the explicit radix parameter. While modern JavaScript defaults to base 10, the codebase convention (seen in worktree-handlers.ts, roadmap-handlers.ts) is to explicitly specify radix 10 for clarity.

Suggested fix:

Add radix parameter: `parseInt(specMatch[1], 10)`, `parseInt(worktreeMatch[1], 10)`, `parseInt(countMatch[2], 10)`

🔵 [d35337fe0c5e] [LOW] formatBytes may produce invalid output for edge case inputs

📁 apps/frontend/src/renderer/components/CleanProjectDialog.tsx:146

The formatBytes function uses Math.log(bytes) which returns NaN for negative values. While file sizes are never negative in practice, defensive coding would handle this case to prevent 'NaN undefined' output from malformed data.

Suggested fix:

Add guard: `if (!Number.isFinite(bytes) || bytes < 0) return '0 B';`

This review was generated by Auto Claude.

StillKnotKnown and others added 5 commits January 11, 2026 14:42
…ndyMik90#905)

* fix(memory): use shared project-wide memory for cross-spec learning

Task execution memory was isolated per spec (GroupIdMode.SPEC), preventing
learnings from one spec from benefiting other specs. Changed all GraphitiMemory
instantiations to use GroupIdMode.PROJECT for shared project-wide context.

This aligns task memory with PR review memory, which already uses shared
databases for cross-session learning.

Fixes AndyMik90#205

* refactor(memory): centralize GraphitiMemory instantiation via helper

Use the existing get_graphiti_memory helper function instead of directly
instantiating GraphitiMemory in multiple places. This reduces code
duplication and improves maintainability by having a single source of
truth for memory creation.

The helper already uses GroupIdMode.PROJECT for cross-spec learning,
so this refactor maintains the original fix while centralizing the logic.

Addresses review comments on AndyMik90#905

* refactor(memory): improve error handling for GraphitiMemory instantiation

Move get_graphiti_memory() calls inside try/except blocks to properly catch
construction errors. Also use explicit 'is None' checks instead of truthiness
to avoid surprising __bool__ behavior.

- In get_graphiti_context: Move memory creation inside try block
- In save_session_memory: Move memory creation inside try block
- In _save_to_graphiti_async: Remove redundant is_graphiti_enabled check,
  use 'is None' for explicit None checking

These changes ensure that any construction errors are caught and handled,
allowing graceful fallback to file-based memory.

Addresses additional review comments on AndyMik90#905

* style(memory): use explicit None checks in finally blocks

Replace truthy checks with explicit 'is not None' checks in finally blocks
for consistency with other explicit None checks in memory_manager.py.

Addresses review comment on AndyMik90#905

* fix(memory): use explicit None check in second finally block

Update the finally block in save_session_memory to use explicit None check
for consistency. The first finally block was updated but this one was missed.

Addresses remaining review comment on AndyMik90#905

* refactor(memory): use finally block for consistent cleanup in save_to_graphiti_async

Refactor save_to_graphiti_async to use a finally block with explicit None
check for resource cleanup, matching the pattern established in memory_manager.py.

Previously, close() was called in both the try and except blocks, which could
lead to resource leaks in certain edge cases. The finally block ensures cleanup
always occurs.

Addresses CodeRabbit review feedback on AndyMik90#905

* refactor(memory): add type hints and improve cleanup safety

- Add return type annotation to get_graphiti_memory() using TYPE_CHECKING
  to avoid circular imports while keeping call sites honest
- Wrap memory.close() in try/except within finally blocks to prevent
  close() exceptions from overriding success/failure flows
- Use explicit 'memory is not None' checks to avoid misleading warnings
  when memory isn't available
- Distinguish between 'memory is None' (not available) and
  'memory.is_enabled is False' (disabled) for clearer logging

Addresses CodeRabbit review feedback on AndyMik90#905

* fix(memory): wrap close() in try/except in save_to_graphiti_async finally

Wrap graphiti.close() in try/except within the finally block to prevent
close() exceptions from overriding successful outcomes. This matches the
pattern established in memory_manager.py for consistent resource cleanup.

Addresses CodeRabbit review feedback on AndyMik90#905

* fix(memory): address follow-up review findings

- Wrap close() in try/except in tools/memory.py finally block to match
  the pattern in graphiti_helpers.py and memory_manager.py, preventing
  close() exceptions from overriding successful outcomes
- Update get_graphiti_memory() default in integrations/graphiti/memory.py
  from GroupIdMode.SPEC to GroupIdMode.PROJECT for consistency with the
  PR's intent of enabling cross-spec learning by default
- Add deprecation note explaining the default change

Addresses follow-up review findings on AndyMik90#905:
- NEW-001: Inconsistent close() handling
- e87df0a37e94: Duplicate get_graphiti_memory function with different default

* refactor(memory): log close failures at debug level

Update all finally blocks to log memory.close() failures at debug level
instead of silently swallowing them. This provides useful diagnostics
while still preventing close() exceptions from overriding the main result.

Changes:
- tools/memory.py: Add logger.debug() with exc_info for close failures
- graphiti_helpers.py: Add logger.debug() with exc_info for close failures
- memory_manager.py: Add logger.debug() with exc_info for close failures (2 locations)

The debug-level logging ensures close failures are visible for debugging
but do not affect the primary operation outcome.

Addresses review feedback on AndyMik90#905

* fix(memory): log close failures in nested finally block

Add debug logging to the nested finally block in save_session_memory
that was missed by the previous replace_all operation due to different
indentation levels. This ensures all close failures are logged at debug
level for debugging purposes while still preventing them from overriding
the main result.

Addresses review feedback on AndyMik90#905

* fix(logging): use exc_info=True for proper traceback in debug logs

Change logger.debug calls to use exc_info=True instead of exc_info=e
when logging close failures. This ensures the current exception's traceback
is included in the log output for better debugging.

exc_info=e only includes the exception object but not the traceback,
while exc_info=True captures the full traceback information from the
current exception context.

Changes:
- memory_manager.py: Update both finally blocks (2 locations)
- graphiti_helpers.py: Update finally block
- tools/memory.py: Update finally block

Addresses review feedback on AndyMik90#905

---------

Co-authored-by: StillKnotKnown <[email protected]>
Co-authored-by: Andy <[email protected]>
…ling (AndyMik90#839)

* fix(ACS-175): Resolve integrations freeze and improve rate limit handling

* fix(i18n): replace hardcoded toast strings with translation keys

Addresses CodeRabbit review feedback on PR AndyMik90#839:
- OAuthStep.tsx: use t() for all toast messages
- RateLimitModal.tsx: use t() for toast messages
- SDKRateLimitModal.tsx: add useTranslation hook, use t() for toasts
- Add toast translation keys to en/fr onboarding.json and common.json

* fix: replace console.log with debugLog in IntegrationSettings

Addresses CodeRabbit review feedback - use project's debug logging
utility for consistent and toggle-able logging in production.

* fix: replace console.log with debugLog in main process files

Addresses Auto-Claude PR Review feedback:
- terminal-handlers.ts: 14 console.log → debugLog
- pty-manager.ts: 10 console.log → debugLog/debugError
- terminal-manager.ts: 4 console.log → debugLog/debugError

Also fixes:
- Extract magic numbers to CHUNKED_WRITE_THRESHOLD/CHUNK_SIZE constants
- Add terminal validity check before chunked writes
- Consistent error handling (no rethrow for fire-and-forget semantics)

* fix: address Auto Claude PR review findings - console.error→debugError + i18n

- Replace 8 remaining console.error/warn calls with debugError/debugLog:
  - terminal-handlers.ts: lines 59, 426, 660, 671
  - terminal-manager.ts: lines 88, 320
  - pty-manager.ts: lines 88, 141
  - Fixed duplicate logging in exception handler

- Add comprehensive i18n for SDKRateLimitModal.tsx (~20 strings):
  - Added rateLimit.sdk.* keys with swap notifications, buttons, labels
  - EN + FR translations in common.json

- Add comprehensive i18n for OAuthStep.tsx (~15 strings):
  - Added oauth.badges.*, oauth.buttons.*, oauth.labels.* keys
  - EN + FR translations in onboarding.json

All MEDIUM severity findings resolved except race condition (deferred).

* fix: address Auto Claude PR review findings - race condition + console.error

- Fix race condition in chunked PTY writes by serializing writes per terminal
  using Promise chaining (prevents interleaving of concurrent large writes)
- Fix missing 't' in useEffect dependency array in OAuthStep.tsx
- Convert all remaining console.error calls to debugError for consistency:
  - IntegrationSettings.tsx (9 occurrences)
  - RateLimitModal.tsx (3 occurrences)
  - SDKRateLimitModal.tsx (4 occurrences)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Black Circle Sentinel <[email protected]>

---------

Signed-off-by: Black Circle Sentinel <[email protected]>
Co-authored-by: Andy <[email protected]>
Co-authored-by: Adam Slaker <[email protected]>
Co-authored-by: Claude Opus 4.5 <[email protected]>
… messages (ACS-219) (AndyMik90#933)

* fix(frontend): strip ANSI escape codes from roadmap/ideation progress messages (ACS-219)

- Create ansi-sanitizer.ts utility with stripAnsiCodes() function
- Apply to roadmap and ideation progress handlers in agent-queue.ts
- Add 34 comprehensive test cases covering ANSI escape patterns
- Fixes raw escape codes (e.g., \x1b[90m) displaying in UI

* fix(frontend): extract first line before truncating roadmap progress messages

Make roadmap progress message construction consistent with ideation by
extracting the first line (split by newline) before applying the 200
character truncation. This ensures multi-line log output doesn't display
partial lines in the UI.

* refactor(frontend): extract repeated status message formatting to helper

Add formatStatusMessage() helper function to centralize the sanitize+truncate
pattern used in progress message handlers. This improves maintainability by:

- Adding STATUS_MESSAGE_MAX_LENGTH constant (200)
- Encapsulating ANSI stripping, line extraction, and truncation
- Replacing 4 duplicated call sites with single helper

Refactors lines 442, 461, 704, 718 to use formatStatusMessage(log).

---------

Co-authored-by: StillKnotKnown <[email protected]>
…ndyMik90#918)

* fix(frontend): prevent "Render frame was disposed" crash (ACS-211)

Add safeSendToRenderer helper that validates frame state before IPC sends.
Prevents app crash when renderer frames are disposed during heavy agent output.

Fixes AndyMik90#211

Signed-off-by: StillKnotKnown <[email protected]>

* refactor(utils): replace setInterval with timestamp-based cooldown, add \r\n support

- Replace setInterval-based cooldown with timestamp Map approach to avoid timer leaks
- Add isWithinCooldown() and recordWarning() helper functions
- Optionally prune old entries when Map exceeds 100 entries
- Update parseEnvFile to handle Windows \r\n line endings with /\r?\n/ regex

Signed-off-by: StillKnotKnown <[email protected]>

* refactor(utils): enforce hard cap of 100 entries in pruning logic

- First remove expired entries (outside cooldown period)
- If still over 100 entries, remove oldest by insertion order
- Ensures Map never exceeds 100 entries even during heavy load

Signed-off-by: StillKnotKnown <[email protected]>

* test: fix module-level state issue in pruning tests

- Add _clearWarnTimestampsForTest() helper to clear module-level Map
- Call clear in parent beforeEach to ensure clean state for each test
- Simplify pruning tests to avoid complex cooldown timing issues
- All 28 tests now pass

* fix: update generation-handlers.ts to use safeSendToRenderer

Addresses finding NEW-003 from follow-up review:
- Import safeSendToRenderer from '../utils'
- Replace all 5 direct webContents.send() calls with safeSendToRenderer
- Add getMainWindow wrapper for each function

This ensures ideation generation IPC messages are protected from
"Render frame was disposed" crashes.

Related: ACS-211

---------

Signed-off-by: StillKnotKnown <[email protected]>
Co-authored-by: StillKnotKnown <[email protected]>
…CS-209) (AndyMik90#915)

* fix(core): implement atomic JSON writes to prevent file corruption (ACS-209)

- Add write_json_atomic() utility using temp file + os.replace()
- Add async_save() to ImplementationPlan for non-blocking I/O
- Update planner.py to use async_save() in async context
- Add 'error' status to TaskStatus for corrupted files
- Enhance ProjectStore error handling to surface parse errors
- Add recovery CLI utility (cli/recovery.py) for detecting/fixing corrupted files

This fixes JSON parse errors that caused tasks to be silently skipped
when implementation_plan.json was corrupted during crashes/interrupts.

* fix(i18n): add error column to task status constants and translations

- Add 'error' to TASK_STATUS_COLUMNS array
- Add 'error' label and color to TASK_STATUS_LABELS and TASK_STATUS_COLORS
- Add 'columns.error' translation key to en/tasks.json and fr/tasks.json

This fixes TypeScript errors in KanbanBoard.tsx where the Record type
was missing the 'error' status that was added to TaskStatus type.

* refactor: improve code quality and add i18n support for error messages

Backend improvements:
- Fix duplicate JSON check in recovery.py (remove redundant plan_file check)
- Update find_specs_dir return type to Path (always returns valid path)
- Replace deprecated asyncio.get_event_loop() with asyncio.get_running_loop()
- Use functools.partial for cleaner async_save implementation

Frontend improvements:
- Add TaskErrorInfo type for structured error information
- Update project-store.ts to use errorInfo for i18n-compatible error messages
- Tighten typing of TASK_STATUS_LABELS and TASK_STATUS_COLORS to use TaskStatusColumn
- Add error column to KanbanBoard grouped tasks initialization
- Add en/fr errors.json translation files for parse error messages

* docs: add errors.json to i18n translation namespaces

- Document new errors.json namespace for error messages
- Add example showing interpolation/substitution pattern for dynamic error content

* refactor: typing improvements, i18n fixes, and error UX enhancements

Backend typing:
- Add explicit return type hint (-> None) to main() in recovery.py
- Add explicit return type hint (-> None) to async_save() in plan.py
- Make recovery.py exit with code 1 when corrupted files are detected

Error handling improvements:
- Include specId in errorInfo meta for better error context
- Cap error message length at 500 characters to prevent bloat
- Update error translation keys to include specId substitution

Frontend improvements:
- Conditionally add reviewReason/errorInfo to task objects only when defined
- Add 'error' case to KanbanBoard empty state with AlertCircle icon
- Fix hardcoded "Refreshing..."/"Refresh Tasks" strings to use i18n

i18n additions:
- Add emptyError/emptyErrorHint to en/fr tasks.json
- Add refreshing/refreshTasks to en/fr translation files

* refactor: code quality improvements

- Remove error truncation in recovery.py (show full error for debugging)
- Extract duplicate timestamp/status update logic to _update_timestamps_and_status() helper
- Fix MD031 in CLAUDE.md (add blank line before fenced code block)

* refactor: code quality improvements

- Remove error truncation in recovery.py (show full error for debugging)
- Extract duplicate timestamp/status update logic to _update_timestamps_and_status() helper
- Fix MD031 in CLAUDE.md (add blank line before fenced code block)

* refactor: naming and typing improvements

- Update docstring examples in recovery.py (--fix -> --delete)
- Rename delete_corrupted_file to backup_corrupted_file for clarity
- Add return type annotation -> None to save() method

* fix: add error status handling to TaskCard

- Add 'error' case to getStatusBadgeVariant() returning 'destructive'
- Add 'error' case to getStatusLabel() returning t('columns.error')
- Start/stop buttons already exclude error tasks (backlog/in_progress only)

* fix: address PR review feedback

Backend changes:
- recovery.py: Change [DELETE] to [BACKUP] in output message to match operation
- recovery.py: Replace startswith with is_relative_to for proper path validation
- recovery.py: Handle existing .corrupted backup files with unique timestamp suffix
- file_utils.py: Add Iterator[IO[str]] return type annotation to atomic_write

Frontend changes:
- KanbanBoard.tsx: Use column-error CSS class instead of inline border-t-destructive
- globals.css: Add .column-error rule with destructive color for consistency
- tasks.json: Add top-level refreshTasks translation key for en/fr locales

* fix: address follow-up review findings

Backend changes:
- file_utils.py: Handle binary mode correctly (encoding=None for 'b' in mode)
- file_utils.py: Change return type to Iterator[IO] for broader type support
- file_utils.py: Add docstring note about binary mode support
- plan.py: Fix async_save to restore state on write failure (captures timestamps)

Frontend changes:
- project-store.ts: Add 'error' to statusMap to preserve error status
- project-store.ts: Add early return for 'error' status like 'done'/'pr_created'
- task-store.ts: Allow recovery from error status to backlog/in_progress
- task-store.ts: Allow transitions to error without completion validation

* fix: address follow-up review findings

Backend changes:
- file_utils.py: Handle binary mode correctly (encoding=None for 'b' in mode)
- file_utils.py: Change return type to Iterator[IO] for broader type support
- file_utils.py: Add docstring note about binary mode support
- plan.py: Fix async_save to restore state on write failure (captures timestamps)

Frontend changes:
- project-store.ts: Add 'error' to statusMap to preserve error status
- project-store.ts: Add early return for 'error' status like 'done'/'pr_created'
- task-store.ts: Allow recovery from error status to backlog/in_progress
- task-store.ts: Allow transitions to error without completion validation

* fix: address third follow-up review findings

Backend changes:
- recovery.py: Change spec_dir.glob to spec_dir.rglob for recursive JSON scan
- file_utils.py: Fix fd leak when os.fdopen raises (close fd and unlink tmp_path)
- plan.py: Capture full state with to_dict() for robust rollback in async_save

* fix: address final review quality suggestions

Backend changes:
- plan.py: Add NOTE comment about rollback fields maintenance
- file_utils.py: Add logging.warning for temp file cleanup failures

* fix: address final review quality suggestions

Backend changes:
- plan.py: Add NOTE comment about rollback fields maintenance
- file_utils.py: Add logging.warning for temp file cleanup failures

* fix: address final review quality suggestions

Backend changes:
- plan.py: Add NOTE comment about rollback fields maintenance
- file_utils.py: Add logging.warning for temp file cleanup failures

* fix: include stack trace in temp file cleanup failure logging

Add exc_info=True to logging.warning call when temp file cleanup fails.
This captures the full stack trace for better postmortem debugging of
orphaned temp files.

---------

Co-authored-by: StillKnotKnown <[email protected]>
Co-authored-by: Andy <[email protected]>
@Batch0101 Batch0101 requested a review from AndyMik90 January 12, 2026 13:38
StillKnotKnown and others added 4 commits January 12, 2026 14:46
…yMik90#945) (AndyMik90#946)

* fix(workspace): auto-rebase spec branch when behind before merge (ACS-224)

When the "Merge with AI" button is clicked and the spec branch is behind
the target branch, the system now automatically rebases before attempting
to merge. Previously, the merge preview correctly detected the "behind"
state but the actual merge process would fail with conflict errors.

Changes:
- Enhanced _check_git_conflicts() to detect needs_rebase and commits_behind
- Added _rebase_spec_branch() to automatically rebase spec branch
- Integrated rebase logic into _try_smart_merge_inner() before conflict resolution
- Added 10 comprehensive tests for rebase detection and execution

* fix(workspace): correct rebase invocation and use run_git helper

Fixes issues in _rebase_spec_branch function:
- Use run_git() instead of subprocess.run for allowlist compliance
- Fix fragile git rebase arg order - use standard invocation
- Remove misleading --strategy-option=theirs (not actually used)
- Return False when conflicts abort (no ref movement occurred)
- Verify branch actually moved after successful rebase

Also updates test to check both .git/rebase-merge and .git/rebase-apply
directories for robust git version compatibility.

* fix: address PR review findings for rebase function

Fixes 7 issues identified in PR review:

HIGH:
- Save and restore original branch after rebase (prevents leaving repo on spec branch)

MEDIUM:
- Return True when branch is already up-to-date (success, not failure)
- Fix conflict detection to parse git status codes properly (not 'U' substring)
- Check rebase abort result for inconsistent state

LOW:
- Remove unused variables git_dir and git_backup from test
- Deduplicate git_conflicts.get('commits_behind', 0) call
- Rename test to accurately describe what it tests

* fix: address follow-up PR review findings

Additional fixes from code review:

workspace.py:
- Remove duplicate "UD" from conflict status codes tuple
- Add returncode check for original_branch_result with proper validation
- Guard finally block restore with original_branch validity check
- Replace subprocess.run with run_git for rev-list call
- Add error logging when rev-list fails

test_workspace.py:
- Remove duplicate test test_rebase_handles_nonexistent_branch_gracefully
  (redundant with test_rebase_spec_branch_invalid_branch)
- Strengthen merge assertion from "is not None" to "is True"

* fix: replace remaining subprocess.run with run_git and add comprehensive tests

workspace.py:
- Replace all subprocess.run calls in _check_git_conflicts with run_git
  for consistent error handling, timeout handling, and centralized logging

test_workspace.py:
- Add test_rebase_spec_branch_already_up_to_date to verify function
  returns True when spec branch is already current
- Add test_check_git_conflicts_handles_detached_head to verify graceful
  handling of detached HEAD state
- Add test_check_git_conflicts_handles_corrupted_repo to verify graceful
  handling of corrupted .git directory with proper cleanup
- Fix test_check_git_conflicts_no_commits_behind to checkout main before
  assertion (was comparing spec to itself, always returning 0)

Test count: 42 -> 45 (+3 new tests)

* fix: remove unused tempfile import from test

* fix(workspace): final PR review fixes for ACS-224 rebase functionality

This commit addresses the final batch of PR review findings for the rebase
functionality added in ACS-224. All 45 tests pass.

Changes:
- NEW-001: Added branch restoration failure tracking and logging in finally
  block (noted limitation: cannot return False from finally block)
- NEW-002: Added abort_failed tracking and checks before returning True
  to propagate abort failures to caller
- NEW-004: Added state verification assertions to test_rebase_spec_branch_invalid_branch
  to verify current branch, no rebase state directories, and clean git status
- LOGIC-002: Wrapped int() conversion in try-except to handle malformed
  rev-list output gracefully
- LOGIC-003: Simplified redundant condition from checking both needs_rebase
  and commits_behind > 0 to just checking needs_rebase (which implies > 0)

Files modified:
- apps/backend/core/workspace.py: Added abort_failed tracking and error handling
- tests/test_workspace.py: Added repo state verification assertions

Related: ACS-224

* fix(workspace): fix CodeQL warnings for unreachable code and unused variable

CodeQL detected unreachable code and unused variable issues in the rebase
function. The abort_failed flag was only set when rebase failed, but was
only checked in the success path (making it unreachable).

Fixed by:
- Removing abort_failed variable and its unreachable checks
- Immediately returning False when abort fails (cannot safely continue)
- Simplifying the finally block comment to reflect actual behavior

All 45 tests pass.

Related: ACS-224

---------

Co-authored-by: StillKnotKnown <[email protected]>
* chore: bump version to 2.7.3

* chore: update CHANGELOG for version 2.7.3, highlighting new features, improvements, and bug fixes

---------

Co-authored-by: Test User <[email protected]>
- Merge main into develop to sync 6 missing commits (v2.7.2 hotfixes, CI fixes)
- Keep develop's 2.7.3 release content for CHANGELOG and features
- Fix CodeQL issues:
  - Add comments to empty except blocks in git_executable.py
  - Add comments to empty except blocks in modification_tracker.py
  - Add comments to empty except blocks in pr_worktree_manager.py
  - Consolidate ctypes imports in capabilities.py
  - Remove unused imports (sys, time, timedelta, pytest) from test files
- Keep main's shell variable interpolation fix in release.yml

Co-Authored-By: Claude Opus 4.5 <[email protected]>
High Priority Fixes:
- Add process timeout (30s preview, 5min cleanup) to prevent indefinite hangs
- Add null check for duration.toFixed() to prevent TypeError crashes

Medium Priority Fixes:
- Add null checks for optional fields (count, size, duration) with safe defaults
- Fix parseCleanupResult to return null on parsing failure (track foundAnyData)

Low Priority Fixes:
- Add radix parameter (10) to all parseInt calls to prevent octal interpretation
- Add defensive guards to formatBytes for NaN, Infinity, negative values, and index bounds

All fixes are additive safety checks with no breaking changes.

Signed-off-by: Batch0101 <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In @apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts:
- Around line 270-305: The Promise can be resolved twice because the timeout
handler calls resolve after kill('SIGTERM') and the process 'close' handler will
also call resolve; add a resolved guard and ensure all handlers only resolve
once: introduce a boolean (e.g., "settled") checked/set before every resolve,
and after settling remove or noop the other listeners and clear the timeout;
update the handlers on cleanupProcess ('close' and 'error') and the timeout
callback to check/set "settled" and to perform listener cleanup so only the
first terminal event resolves the Promise.

In @apps/frontend/src/renderer/components/CleanProjectDialog.tsx:
- Around line 94-106: The useEffect that resets state on dialog close uses
setTimeout without cleanup, risking state updates after unmount; capture the
timeout id when calling setTimeout inside the effect that watches open and
return a cleanup function that calls clearTimeout(timeoutId) to cancel it, so
update logic in the effect that calls setStep, setPreview, setSelectedMode,
setConfirmText, setResult, and setError is only run if the timeout completes and
not after unmount.
- Around line 175-179: The confirmation word is hardcoded; update
handleConfirmClick to compare confirmText (and the input placeholder and
canProceed logic) against a localized string instead of the literal 'clean'—use
the translation key t('common:cleanProject.confirmWord') for both the comparison
and the placeholder/typeToConfirm UI text, or if the word is intentionally
language-agnostic, document that decision and ensure typeToConfirm explains
which token to type; adjust references in handleConfirmClick, the input
placeholder, and canProceed accordingly and add the confirmWord entries to
locale files.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1193f9 and 52d4767.

📒 Files selected for processing (2)
  • apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts
  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
🧰 Additional context used
📓 Path-based instructions (2)
apps/frontend/src/**/*.{tsx,ts}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/frontend/src/**/*.{tsx,ts}: Use i18n translation keys for all user-facing text in the frontend. All labels, buttons, messages must use translation keys from react-i18next with namespace:section.key format (e.g., 'navigation:items.githubPRs').
Never use hardcoded strings for UI text in JSX/TSX files. Always use translation keys via useTranslation() hook.

Files:

  • apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts
  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
apps/frontend/**/*.{ts,tsx}

⚙️ CodeRabbit configuration file

apps/frontend/**/*.{ts,tsx}: Review React patterns and TypeScript type safety.
Check for proper state management and component composition.

Files:

  • apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts
  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
🧠 Learnings (6)
📓 Common learnings
Learnt from: MikeeBuilds
Repo: AndyMik90/Auto-Claude PR: 661
File: apps/frontend/src/renderer/components/onboarding/OllamaModelSelector.tsx:176-189
Timestamp: 2026-01-04T23:59:48.743Z
Learning: In the AndyMik90/Auto-Claude repository, pre-existing i18n issues (hardcoded user-facing strings that should be localized) can be deferred to future i18n cleanup passes rather than requiring immediate fixes in PRs that don't introduce new i18n violations.
📚 Learning: 2026-01-12T13:47:32.539Z
Learnt from: CR
Repo: AndyMik90/Auto-Claude PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-12T13:47:32.539Z
Learning: Applies to apps/frontend/src/**/*.{tsx,ts} : Use i18n translation keys for all user-facing text in the frontend. All labels, buttons, messages must use translation keys from react-i18next with namespace:section.key format (e.g., 'navigation:items.githubPRs').

Applied to files:

  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
📚 Learning: 2026-01-12T13:47:32.539Z
Learnt from: CR
Repo: AndyMik90/Auto-Claude PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-12T13:47:32.539Z
Learning: Applies to apps/frontend/src/**/*.{tsx,ts} : Never use hardcoded strings for UI text in JSX/TSX files. Always use translation keys via useTranslation() hook.

Applied to files:

  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
📚 Learning: 2026-01-04T23:59:45.209Z
Learnt from: MikeeBuilds
Repo: AndyMik90/Auto-Claude PR: 661
File: apps/frontend/src/renderer/components/onboarding/OllamaModelSelector.tsx:176-189
Timestamp: 2026-01-04T23:59:45.209Z
Learning: In the AndyMik90/Auto-Claude repository, pre-existing i18n issues (hardcoded user-facing strings) can be deferred for future i18n cleanup passes. Do not fix such issues in PRs that do not introduce new i18n violations, especially in frontend TSX components (e.g., apps/frontend/**/*.tsx). If a PR adds new i18n violations, address them in that PR.

Applied to files:

  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
📚 Learning: 2026-01-12T13:47:32.539Z
Learnt from: CR
Repo: AndyMik90/Auto-Claude PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-12T13:47:32.539Z
Learning: Applies to apps/frontend/src/shared/i18n/locales/**/*.json : Add new translation keys to ALL language files (at minimum: en/*.json and fr/*.json) in apps/frontend/src/shared/i18n/locales/ when adding new UI text.

Applied to files:

  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
📚 Learning: 2026-01-10T15:30:12.808Z
Learnt from: taniar88
Repo: AndyMik90/Auto-Claude PR: 883
File: apps/frontend/src/main/agent/agent-process.ts:21-21
Timestamp: 2026-01-10T15:30:12.808Z
Learning: In the AndyMik90/Auto-Claude repository, new languages should only be added to AVAILABLE_LANGUAGES constant in apps/frontend/src/shared/constants/i18n.ts once their UI translations are complete in apps/frontend/src/shared/i18n/locales/. This avoids implying official support for incomplete translations and prevents user-facing issues.

Applied to files:

  • apps/frontend/src/renderer/components/CleanProjectDialog.tsx
🧬 Code graph analysis (1)
apps/frontend/src/renderer/components/CleanProjectDialog.tsx (2)
apps/backend/runners/github/cleanup.py (1)
  • CleanupResult (103-143)
.design-system/src/components/Input.tsx (1)
  • Input (4-24)
🔇 Additional comments (12)
apps/frontend/src/main/ipc-handlers/cleanup-handlers.ts (5)

9-31: LGTM!

The interface definitions are well-structured and appropriately model the cleanup data types. The optional fields for specCount and worktreeCount properly reflect their conditional presence in the parsed output.


41-111: LGTM!

The parseCleanupPreview function handles parsing robustly with:

  • Proper state machine for tracking list sections
  • Null return on empty items for clear failure signaling
  • Appropriate try-catch for unexpected parsing errors

The regex patterns correctly extract sizes, spec counts, and worktree counts from the Python script output format.


121-137: LGTM!

The parseSizeString function correctly converts human-readable sizes to bytes with proper handling for all common units (B, KB, MB, GB, TB) using binary multipliers (1024).


147-186: LGTM!

Good defensive implementation - the foundAnyData flag ensures null is returned when parsing yields no meaningful data, preventing false positives with zeroed results.


314-420: LGTM!

The IPC handler registration is well-structured with:

  • Proper error handling and logging throughout
  • Defensive defaults when preview parsing returns null (empty preview instead of error)
  • Nullish coalescing (?? 0) on result fields for robustness
  • Clear separation between preview (dry-run) and execute paths
apps/frontend/src/renderer/components/CleanProjectDialog.tsx (7)

1-15: LGTM!

Imports are well-organized with proper use of useTranslation hook for i18n support.


65-85: LGTM!

The loadPreview callback properly handles loading states, error states, and uses localized error messages via t().


108-141: LGTM!

The executeCleanup callback properly:

  • Guards against missing prerequisites
  • Manages loading/step states through the flow
  • Handles both success and error cases with localized messages
  • Returns to preview step on failure for retry capability

143-159: LGTM!

Excellent defensive implementation of formatBytes with proper handling for:

  • NaN/Infinity via Number.isFinite()
  • Negative values
  • Zero bytes
  • Index bounds clamping for the units array

This aligns with the safety fixes mentioned in the commit.


187-323: LGTM!

The renderPreview function is well-implemented:

  • Handles loading, error, and empty states appropriately
  • Uses translation keys for all labels and messages
  • Mode selection UI provides clear visual feedback with appropriate styling
  • Item display with localized names via getItemDisplayName

365-398: LGTM!

The renderResult function properly:

  • Guards against null result
  • Uses localized strings with interpolation for count/size
  • Shows appropriate error styling for failure cases
  • Handles duration with defensive ?? 0 fallback

420-477: LGTM!

The Dialog structure is well-composed:

  • Proper use of dialog primitives
  • Conditional rendering based on step state
  • Button states and variants appropriately reflect current mode and step
  • All button labels use translation keys

Batch0101 and others added 9 commits January 12, 2026 09:24
- Fix race condition: add resolved flag to prevent double promise resolution
- Fix memory leak: add cleanup function to useEffect with setTimeout
- Fix i18n violation: use translation key for confirmation word validation

Signed-off-by: Batch0101 <[email protected]>
- Fix shell command injection vulnerability in cli-tool-manager.ts
  by using cmd.exe with argument array instead of string interpolation
- Fix unused variables in test files (PRDetail.test.tsx, ReviewStatusTree.test.tsx)
- Remove unused 'issues' destructuring in GitLabIssues.tsx
- Fix unused 'merge_base' variable in workspace.py
- Remove INVESTIGATION.md (temporary investigation document)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Fix prepare-release.yml to use npx semver for proper version comparison
  (sort -V incorrectly ranked 2.7.3-beta.1 > 2.7.3)
- Add workflow_dispatch trigger with force option for manual releases
- Fix CHANGELOG.md formatting (remove # that caused header rendering)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ndyMik90#961)

* fix(worktree): handle "already up to date" case correctly (ACS-226)

When git merge returns non-zero for "Already up to date", the merge
code incorrectly treated this as a conflict and aborted. Now checks
git output to distinguish between:
- "Already up to date" - treat as success (nothing to merge)
- Actual conflicts - abort as before
- Other errors - show actual error message

Also added comprehensive tests for edge cases:
- Already up to date with no_commit=True
- Already up to date with delete_after=True
- Actual merge conflict detection
- Merge conflict with no_commit=True

* test: strengthen merge conflict abort verification

Improve assertions in conflict detection tests to explicitly verify:
- MERGE_HEAD does not exist after merge abort
- git status returns clean (no staged/unstaged changes)

This is more robust than just checking for absence of "CONFLICT"
string, as git status --porcelain uses status codes, not literal words.

* test: add git command success assertions and branch deletion verification

- Add explicit returncode assertions for all subprocess.run git add/commit calls
- Add branch deletion verification in test_merge_worktree_already_up_to_date_with_delete_after
- Ensures tests fail early if git commands fail rather than continuing silently

---------

Co-authored-by: StillKnotKnown <[email protected]>
- Update all stable download links from 2.7.2 to 2.7.3
- Add Flatpak download link (new in 2.7.3)
…rdering (AndyMik90#985)

* fix(terminal): add collision detection for terminal drag and drop reordering

Add closestCenter collision detection to DndContext to fix terminal
drag and drop swapping not detecting valid drop targets. The default
rectIntersection algorithm required too much overlap for grid layouts.

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(terminal): handle file drops when closestCenter returns sortable ID

Address PR review feedback:
- Fix file drop handling to work when closestCenter collision detection
  returns the sortable ID instead of the droppable ID
- Add terminals to useCallback dependency array to prevent stale state

Co-Authored-By: Claude Opus 4.5 <[email protected]>

---------

Co-authored-by: Claude Opus 4.5 <[email protected]>
@MikeeBuilds MikeeBuilds added feature New feature or request area/frontend This is frontend only needs-triage New issue, maintainer review needed size/L Large (500-999 lines) labels Jan 12, 2026
MikeeBuilds and others added 2 commits January 12, 2026 22:17
…iles (AndyMik90#900)

* fix(ACS-181): enable auto-switch for OAuth-only profiles

Add OAuth token check at the start of isProfileAuthenticated() so that
profiles with only an oauthToken (no configDir) are recognized as
authenticated. This allows the profile scorer to consider OAuth-only
profiles as valid alternatives for proactive auto-switching.

Previously, isProfileAuthenticated() immediately returned false if
configDir was missing, causing OAuth-only profiles to receive a -500
penalty in the scorer and never be selected for auto-switch.

Fixes: ACS-181

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Black Circle Sentinel <[email protected]>

* fix(ACS-181): detect 'out of extra usage' rate limit messages

The previous patterns only matched "Limit reached · resets ..." but
Claude Code also shows "You're out of extra usage · resets ..." which
wasn't being detected. This prevented auto-switch from triggering.

Added new patterns to both output-parser.ts (terminal) and
rate-limit-detector.ts (agent processes) to detect:
- "out of extra usage · resets ..."
- "You're out of extra usage · resets ..."

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(ACS-181): add real-time rate limit detection and debug logging

- Add real-time rate limit detection in agent-process.ts processLog()
  so rate limits are detected immediately as output appears, not just
  when the process exits
- Add clear warning message when auto-switch is disabled in settings
- Add debug logging to profile-scorer.ts to trace profile evaluation
- Add debug logging to rate-limit-detector.ts to trace pattern matching

This enables immediate detection and auto-switch when rate limits occur
during task execution.

Co-Authored-By: Claude Opus 4.5 <[email protected]>

* fix(frontend): enable auto-switch on 401 auth errors

- Propagate 401/403 errors from fetchUsageViaAPI to checkUsageAndSwap in UsageMonitor to trigger proactive profile swapping.
- Fix usage monitor race condition by ensuring it waits for ClaudeProfileManager initialization.
- Fix isProfileAuthenticated to correctly validate OAuth-only profiles.

* fix(ACS-181): address PR review feedback

- Revert unrelated files (rate-limit-detector, output-parser, agent-process) to upstream state
- Gate profile-scorer logging behind DEBUG flag
- Fix usage-monitor type safety and correct catch block syntax
- Fix misleading indentation in index.ts app updater block

* fix(frontend): enforce eslint compliance for logs in profile-scorer

- Replace all console.log with console.warn (per linter rules)
- Strictly gate all debug logs behind isDebug check to prevent production noise

* fix(ACS-181): add swap loop protection for auth failures

- Add authFailedProfiles Map to track profiles with recent auth failures
- Implement 5-minute cooldown before retrying failed profiles
- Exclude failed profiles from swap candidates to prevent infinite loops
- Gate TRACE logs behind DEBUG flag to reduce production noise
- Change console.log to console.warn for ESLint compliance

---------

Signed-off-by: Black Circle Sentinel <[email protected]>
Co-authored-by: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend This is frontend only feature New feature or request needs-triage New issue, maintainer review needed size/L Large (500-999 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.